saherelm/MQL5Data
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Spread Passing for Signalling and Conditions Processing ...

Browse Source
This commit is contained in:
saherelm
2024-12-09 23:04:42 +03:30
parent 317e8b8ba3
commit 812e468151
7 changed files with 475 additions and 282 deletions
Download Patch File Download Diff File Expand all files Collapse all files
X121SMCEA/Classes/x-121.smc.base.strategy.class.mq5
+113 -186
View File
@@ -235,6 +235,60 @@ class XCX121SMCBaseStrategy : public XCBaseAlert
mMaxAllowedSpread = value;
}
/**
* Get Min Required Ticks Verification for Spread Pass ...
*
* @return ( int )
*/
int MinRequiredTicksForSpreadPass()
{
return mMinRequiredTicksForSpreadPass;
}
/**
* Set Min Required Ticks Verification for Spread Pass ...
*
* @param value: Integer ...
*/
void MinRequiredTicksForSpreadPass(int value)
{
//
if (value < 100)
{
value = 100;
}
//
mMinRequiredTicksForSpreadPass = value;
}
/**
* Get Max Allowed Save Ticks ...
*
* @return ( int )
*/
int MaxAllowedSaveTicks()
{
return mMaxAllowedSaveTicks;
}
/**
* Set Max Allowed Save Ticks ...
*
* @param value: Integer ...
*/
void MaxAllowedSaveTicks(int value)
{
//
if (value < 150)
{
value = 150;
}
//
mMaxAllowedSaveTicks = value;
}
/**
* Get Long Signalling State ...
*
@@ -534,9 +588,9 @@ class XCX121SMCBaseStrategy : public XCBaseAlert
bool result = false;
//
int length = 5;
double pointValue = GetPoints(mSymbol);
double maxAllowedSpread = MaxAllowedSpread();
int minRequiredTicksVerification = MinRequiredTicksForSpreadPass();
if (maxAllowedSpread > 0)
{
maxAllowedSpread *= pointValue;
@@ -546,193 +600,51 @@ class XCX121SMCBaseStrategy : public XCBaseAlert
maxAllowedSpread = 0;
}
//
result = maxAllowedSpread <= 0
? true
: minRequiredTicksVerification > 0;
if (!result)
{
return result;
}
//
int ticksCount = ArraySize(mTicks);
if (ticksCount <= length)
{
return result;
}
//
int start = -1;
int end = -1;
CalculateTicksParams(
start,
end,
length + 1 //
);
result = IsValidIndex(start) &&
IsValidIndex(end);
result = ticksCount >= minRequiredTicksVerification;
if (!result)
{
return result;
}
//
end -= 1;
double spreadAVG = 0;
for (int i = start; i < end; i++)
{
spreadAVG += mTicks[i].spread;
}
spreadAVG /= length;
//
double lastSpread = mTicks[ticksCount - 1].spread;
//
result = lastSpread <= spreadAVG &&
(maxAllowedSpread <= 0
? true
: lastSpread <= maxAllowedSpread);
//
return result;
}
/**
* Check Ticks is Bullish or not ...
*
* @return ( bool )
*/
bool IsTicksBullish()
{
//
bool result = false;
//
int start = -1;
int end = -1;
int requiredBullishTicks = 5;
CalculateTicksParams(
start,
end,
requiredBullishTicks //
);
result = IsValidIndex(start) &&
IsValidIndex(end);
if (!result)
{
return result;
}
//
result = true;
for (int i = start + 1; i < end; i++)
if (maxAllowedSpread > 0)
{
//
XTick iTick = mTicks[i];
XTick prevTick = mTicks[i - 1];
//
bool isBullish = iTick.bid >= prevTick.bid;
result = result && isBullish;
if (!result)
{
break;
}
}
//
return result;
}
/**
* Check Ticks is Bearish or not ...
*
* @return ( bool )
*/
bool IsTicksBearish()
{
//
bool result = false;
//
int start = -1;
int end = -1;
int requiredBearishTicks = 5;
CalculateTicksParams(
start,
end,
requiredBearishTicks //
);
result = IsValidIndex(start) &&
IsValidIndex(end);
if (!result)
{
return result;
}
//
result = true;
for (int i = start + 1; i < end; i++)
{
//
XTick iTick = mTicks[i];
XTick prevTick = mTicks[i - 1];
//
bool isBearish = iTick.bid <= prevTick.bid;
result = result && isBearish;
if (!result)
{
break;
}
}
//
return result;
}
/**
* Check Ticks Has Momentum or not ...
*
* @return ( bool )
*/
bool IsTicksHasMomentum()
{
//
bool result = false;
//
int start = -1;
int end = -1;
int requiredTicksForMomentum = 5;
CalculateTicksParams(
start,
end,
requiredTicksForMomentum //
);
result = IsValidIndex(start) &&
IsValidIndex(end);
if (!result)
{
return result;
}
//
result = true;
int lastDiff = 0;
for (int i = start + 1; i < end; i++)
{
//
XTick iTick = mTicks[i];
XTick prevTick = mTicks[i - 1];
//
int timeDiff = MathAbs((int)iTick.time - (int)prevTick.bid);
if (lastDiff <= 0)
{
lastDiff = timeDiff;
}
result = result && timeDiff >= lastDiff;
if (!result)
{
break;
int end = -1;
int start = -1;
result = CalculateTicksParams(
start,
end,
minRequiredTicksVerification //
);
if (!result) {
return result;
}
//
lastDiff = timeDiff;
for (int i = start; i < end; i++)
{
//
XTick iTick = mTicks[i];
//
result = iTick.spread <= maxAllowedSpread;
if (!result)
{
break;
}
}
}
//
@@ -1475,14 +1387,18 @@ class XCX121SMCBaseStrategy : public XCBaseAlert
// Props ...
//
string mSymbol; // Trading Symbol ...
ENUM_TIMEFRAMES mPeriod; // Trading TimeFrame ...
bool mForceDisabled; // Force Disabled ...
bool mAllowLong; // Allow Long Signals
bool mAllowShort; // Allow Short Signals
double mR2R; // Risk/Rewar Ratio ...
double mVolume; // Static Volume Per Trades ...
double mMaxAllowedSpread; // Max Allowed Spread ...
string mSymbol; // Trading Symbol ...
ENUM_TIMEFRAMES mPeriod; // Trading TimeFrame ...
bool mForceDisabled; // Force Disabled ...
bool mAllowLong; // Allow Long Signals
bool mAllowShort; // Allow Short Signals
double mR2R; // Risk/Rewar Ratio ...
double mVolume; // Static Volume Per Trades ...
//
double mMaxAllowedSpread; // Max Allowed Spread ...
int mMinRequiredTicksForSpreadPass; // Min Required Ticks Verification for Spread Pass ...
int mMaxAllowedSaveTicks; // Max Allowed Save Ticks ...
//
long mChartID; // Chart ID ...
@@ -1506,6 +1422,8 @@ class XCX121SMCBaseStrategy : public XCBaseAlert
//
R2R(1);
Volume(0.01);
MaxAllowedSaveTicks(150);
MinRequiredTicksForSpreadPass(100);
//
ChartIdentification(0);
@@ -1598,7 +1516,6 @@ class XCX121SMCBaseStrategy : public XCBaseAlert
mVisionDetector.MaxNumberOfRequiredPOIs(poiRequired);
mVisionDetector.Init();
//
}
@@ -1636,7 +1553,7 @@ class XCX121SMCBaseStrategy : public XCBaseAlert
void CleanupTicks()
{
//
int maxRequiredTicks = 50;
int maxRequiredTicks = MaxAllowedSaveTicks();
int ticksCount = ArraySize(mTicks);
if (!IsValidSize(ticksCount) ||
ticksCount <= maxRequiredTicks)
@@ -1686,12 +1603,15 @@ class XCX121SMCBaseStrategy : public XCBaseAlert
* @param end: Integer Reference to End ...
* @param numOfLastTicks: Integer Max Number of Required N Last Ticks ...
*/
void CalculateTicksParams(
bool CalculateTicksParams(
int &start,
int &end,
int numOfLastTicks = 5 //
)
{
//
bool result = 0;
//
start = -1;
end = -1;
@@ -1712,6 +1632,13 @@ class XCX121SMCBaseStrategy : public XCBaseAlert
{
end = count;
}
//
result = IsValidIndex(start) &&
IsValidIndex(end);
//
return result;
}
//
X121SMCEA/Classes/x-121.smc.market.cycle.helper.class.mq5
+132 -2
View File
@@ -326,6 +326,16 @@ class XC121SMCCycleHelper : public XCBase
//
result = conditions.IsValid();
//
if (result)
{
//
Calculate(
barIndex,
conditions //
);
}
//
return result;
}
@@ -361,6 +371,7 @@ class XC121SMCCycleHelper : public XCBase
//
double bid = GetBid(bar.symbol);
double ask = GetAsk(bar.symbol);
//
// Retrieve X121 Cnditions ...
@@ -407,7 +418,9 @@ class XC121SMCCycleHelper : public XCBase
//
// Check Zone is Valid For Bar ...
bool isValid = bar.high < iZone.Lower();
bool isValid = bar.high < iZone.Lower() &&
ask < iZone.Lower() &&
bid < iZone.Lower();
if (isValid)
{
//
@@ -511,7 +524,9 @@ class XC121SMCCycleHelper : public XCBase
//
// Check Zone is Valid For Bar ...
bool isValid = bar.low > iZone.Upper();
bool isValid = bar.low > iZone.Upper() &&
ask > iZone.Upper() &&
bid > iZone.Upper();
if (isValid)
{
//
@@ -616,6 +631,121 @@ class XC121SMCCycleHelper : public XCBase
protected:
//
/**
* Calculate Requirements ...
*
* @param barIndex: Integer, Bar Index ...
* @param conditions: X121SMCCycleConditions instance ...
*/
void Calculate(
int barIndex,
X121SMCCycleConditions &conditions //
)
{
//
int index =
barIndex <= 0
? 1
: barIndex;
bool isInited = false;
string symbol = GetSymbol();
//
// Retrieve Bar ...
XOHCL bar;
isInited = GetBar(bar, index);
if (!isInited)
{
return;
}
//
// Retrieve Previous Bar ...
XOHCL pBar;
int pIndex = index + 1;
isInited = GetBar(pBar, pIndex);
if (!isInited)
{
return;
}
//
XTick xTick;
isInited = xTick.Init(symbol);
if (!isInited)
{
return;
}
//
bool isSarAttached =
bar.close > conditions.x121Conditions.sarBuffer[0];
if (isSarAttached)
{
Print("Sar Attached ...");
}
// //
// bool isSarBullish =
// conditions.x121Conditions.sarBuffer[index] < bar.low;
// bool isSarBullishPrev =
// conditions.x121Conditions.sarBuffer[pIndex] < pBar.low;
// //
// bool isSarBearish =
// conditions.x121Conditions.sarBuffer[index] > bar.high;
// bool isSarBearishPrev =
// conditions.x121Conditions.sarBuffer[pIndex] > pBar.high;
// //
// bool isSarSwitchedToBullish =
// isSarBullish &&
// !isSarBullishPrev &&
// isSarBearishPrev;
// //
// bool isSarSwitchedToBearish =
// isSarBearish &&
// !isSarBearishPrev &&
// isSarBullishPrev;
// //
// if (isSarSwitchedToBullish ||
// isSarSwitchedToBearish)
// {
// Print("Sar Switched ...");
// }
// //
// bool isSarBullish =
// conditions.x121Conditions.sarBuffer[1] < xTick.ask &&
// conditions.x121Conditions.sarBuffer[1] < xTick.bid &&
// conditions.x121Conditions.isSarBullish;
// //
// bool isSarBearish =
// conditions.x121Conditions.sarBuffer[1] > xTick.ask &&
// conditions.x121Conditions.sarBuffer[1] > xTick.bid &&
// conditions.x121Conditions.isSarBearish;
//
// Detect Sar Changes ...
// bool isSarChanged = (isSarBullish &&
// !isSarBearish) ||
// (isSarBearish &&
// !isSarBullish);
// if (isSarChanged)
// {
// Print("SarChaned");
// }
//
// Detect Peak Changes ...
//
// Detect Vale Changes ...
}
//
private:
//
X121SMCEA/Experts/x-121.smc.expert.class.mq5
+2
View File
@@ -1000,6 +1000,8 @@ class XC121SMCExpert : public XCBaseExpert
strategy.AllowLong(AllowLong());
strategy.AllowShort(AllowShort());
strategy.MaxAllowedSpread(20);
strategy.MaxAllowedSaveTicks(150);
strategy.MinRequiredTicksForSpreadPass(100);
//
if (Disabled())
X121SMCEA/Strategy/x-121.smc.test.strategy.class.mq5
+53 -53
View File
@@ -123,15 +123,6 @@ class XCX121SMCTestStrategy : public XCX121SMCBaseStrategy
double pip = GetPipPrice(symbol);
double pip2 = 2 * pip;
//
// Detect Conditions ...
result = DetectConditions(conditions);
if (!result)
{
conditions.Clean();
return result;
}
//
// Check Spread ...
bool isSpreadPassed = IsSpreadPass();
@@ -146,6 +137,15 @@ class XCX121SMCTestStrategy : public XCX121SMCBaseStrategy
return result;
}
//
// Detect Conditions ...
result = DetectConditions(conditions);
if (!result)
{
conditions.Clean();
return result;
}
//
// Combine all Signals Conditions ...
selectedSL = conditions.sl;
@@ -425,53 +425,53 @@ class XCX121SMCTestStrategy : public XCX121SMCBaseStrategy
}
conditions.visionConditions.state = mVisionState;
//
// Detect Valid Supply and Demand Zones ...
XCSupplyZone *supplyZone;
XCDemandZone *demandZone;
result = mTriggerCycleHelper
.DetectValisSupplyZone(
cBar,
supplyZone,
demandZone //
);
if (!result)
{
//
conditions.Clean();
return result;
}
// //
// // Detect Valid Supply and Demand Zones ...
// XCSupplyZone *supplyZone;
// XCDemandZone *demandZone;
// result = mTriggerCycleHelper
// .DetectValisSupplyZone(
// cBar,
// supplyZone,
// demandZone //
// );
// if (!result)
// {
// //
// conditions.Clean();
// return result;
// }
//
supplyZone.To(cTime);
XCSupplyZoneObject *iSupplyZoneObj;
result = mPOIDrawer.CreateSupplyZone(
supplyZone,
iSupplyZoneObj //
);
if (!result)
{
//
conditions.Clean();
return result;
}
// //
// supplyZone.To(cTime);
// XCSupplyZoneObject *iSupplyZoneObj;
// result = mPOIDrawer.CreateSupplyZone(
// supplyZone,
// iSupplyZoneObj //
// );
// if (!result)
// {
// //
// conditions.Clean();
// return result;
// }
//
demandZone.To(cTime);
XCDemandZoneObject *iDemandZoneObj;
result = mPOIDrawer.CreateDemandZone(
demandZone,
iDemandZoneObj //
);
if (!result)
{
//
conditions.Clean();
return result;
}
// //
// demandZone.To(cTime);
// XCDemandZoneObject *iDemandZoneObj;
// result = mPOIDrawer.CreateDemandZone(
// demandZone,
// iDemandZoneObj //
// );
// if (!result)
// {
// //
// conditions.Clean();
// return result;
// }
//
Print("Supply and Demand Zone Created ...");
// //
// Print("Supply and Demand Zone Created ...");
//
if (!result)